Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): enable glog to print stack trace autonatically when the process die in planning/control modules #772

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

TakaHoribe
Copy link

@TakaHoribe TakaHoribe commented Aug 25, 2023

Description

glogの導入。ノードが死んだときに自動でターミナルにスタックトレースが印字されるので、解析が楽になります!

image (4)

関連PR:

Tests performed

Now working:

  • xx1での動作確認 in psim
  • 処理負荷が上がらないことの確認 in psim

Effects on system behavior

ノードが死んだときに自動でstack traceが印字される

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

TakaHoribe and others added 3 commits August 25, 2023 23:21
…ion#4714)

* feat(glog): add glog component

Signed-off-by: Takamasa Horibe <[email protected]>

* formatting

Signed-off-by: Takamasa Horibe <[email protected]>

* remove namespace

Signed-off-by: Takamasa Horibe <[email protected]>

* remove license

Signed-off-by: Takamasa Horibe <[email protected]>

* Update launch/tier4_planning_launch/launch/scenario_planning/lane_driving/motion_planning/motion_planning.launch.py

Co-authored-by: Daisuke Nishimatsu <[email protected]>

* Update launch/tier4_planning_launch/launch/scenario_planning/lane_driving/behavior_planning/behavior_planning.launch.py

Co-authored-by: Daisuke Nishimatsu <[email protected]>

* Update common/glog_component/CMakeLists.txt

Co-authored-by: Daisuke Nishimatsu <[email protected]>

* Update launch/tier4_control_launch/launch/control.launch.py

Co-authored-by: Daisuke Nishimatsu <[email protected]>

* add copyright

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
…undation#4746)

* use node instead of include

Signed-off-by: Takamasa Horibe <[email protected]>

* use container & add glog component

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: Takamasa Horibe <[email protected]>
@github-actions github-actions bot added documentation Improvements or additions to documentation launch common labels Aug 25, 2023
@TakaHoribe TakaHoribe changed the title Enable glog to print stack trace autonatically when the process die in planning/control modules feat(launch): enable glog to print stack trace autonatically when the process die in planning/control modules Aug 25, 2023
@TakaHoribe
Copy link
Author

TakaHoribe commented Aug 25, 2023

ちょっと処理負荷が気になるのでマージ待ってください

@TakaHoribe
Copy link
Author

smootherのCPU利用率:
上がPR前(node exe)、下がPR後(コンテナ)。特に変化なし。
image

@TakaHoribe
Copy link
Author

mission plannerとsmootherに関しては、launch変更によるrosparamに変化が無いことを確認済み。

@TakaHoribe
Copy link
Author

@tkimura4 こちら側はマージreadyです!

@tkimura4 tkimura4 merged commit b1f3860 into beta/v0.10.0 Aug 26, 2023
17 of 18 checks passed
@tkimura4 tkimura4 deleted the add-glog branch August 26, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common documentation Improvements or additions to documentation launch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants